[PATCH] D49489: [VPlan] VPlan version of InterleavedAccessInfo.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: lib/Transforms/Vectorize/VPlan.cpp:599
+      if (NewIGIter == Old2New.end())
+        Old2New[IG] = new InterleaveGroup<VPInstruction>(
+            IG->getFactor(), IG->isReverse(), IG->getAlignment());
----------------
rkruppe wrote:
> It doesn't seem like this memory is freed anywhere.
> 
> Reading D49491 it seems to me that the InterleaveGroups allocated here are only needed while the `VPInterleavedAccessInfo` object is alive, so it could free them in its destructor (or even better, store `unique_ptr`s that take care of that automatically).
Yep thanks! They should be freed in VPInterleavedAccessInfo's destructor.


https://reviews.llvm.org/D49489