[PATCH] D49515: [llvm-objcopy, tests] Fix several llvm-objcopy tests

Stella Stamenova via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 19 09:11:40 PDT 2018


stella.stamenova added a comment.

In https://reviews.llvm.org/D49515#1167538, @jakehehrlich wrote:

> What would the consequence be of just converting the bytes to a string and writing that out? I have neither a windows box nor python 3 installed.


I suppose we could try a conversion, but we would have to make a guess on the encoding and that could be a problem also. Do you see a benefit in doing a byte to string conversion over writing the bytes to the buffer?


Repository:
  rL LLVM

https://reviews.llvm.org/D49515





More information about the llvm-commits mailing list