[PATCH] D49473: [MSan] pull insertShadowCheck() into getShadowOriginPtr(). NFC

Alexander Potapenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 19 05:12:48 PDT 2018


glider updated this revision to Diff 156238.
glider added a reviewer: dvyukov.
glider added a comment.

Reverted changes to getShadowOriginPtrUserspace()
Dima noticed that the problem we're trying to solve is essentially inserting two code snippets (one for shadow calculation and one for address check) right before the store to a given address so that the second snippet goes before the first one.
Therefore it's natural to insert the second snippet, and then the first one, i.e. to swap the order of calling materializeStores() and materializeChecks().


https://reviews.llvm.org/D49473

Files:
  lib/Transforms/Instrumentation/MemorySanitizer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49473.156238.patch
Type: text/x-patch
Size: 18690 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180719/751ac340/attachment.bin>


More information about the llvm-commits mailing list