[PATCH] D49508: [Sema] Expr::skipRValueSubobjectAdjustments(): record skipped NoOp casts.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 19 05:05:46 PDT 2018


lebedev.ri updated this revision to Diff 156235.
lebedev.ri retitled this revision from "[CodeGen] VisitMaterializeTemporaryExpr(): don't skip NoOp Casts." to "[Sema] Expr::skipRValueSubobjectAdjustments(): record skipped NoOp casts.".
lebedev.ri edited the summary of this revision.
lebedev.ri added a comment.

In https://reviews.llvm.org/D49508#1167177, @efriedma wrote:

> Would it be enough to accumulate the skipped casts into a SmallVector, like we do for the skipped comma operators?


Duuuh, why did i not try this in the first place?!
That works, thanks!


Repository:
  rC Clang

https://reviews.llvm.org/D49508

Files:
  include/clang/AST/Expr.h
  lib/AST/Expr.cpp
  lib/AST/ExprConstant.cpp
  lib/Analysis/CFG.cpp
  lib/CodeGen/CGExpr.cpp
  lib/CodeGen/CGExprConstant.cpp
  lib/Sema/JumpDiagnostics.cpp
  lib/StaticAnalyzer/Core/ExprEngine.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49508.156235.patch
Type: text/x-patch
Size: 7730 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180719/eea51f4b/attachment.bin>


More information about the llvm-commits mailing list