[compiler-rt] r337428 - Rename __asan_gen_* symbols to ___asan_gen_*.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 18 15:23:14 PDT 2018


Author: pcc
Date: Wed Jul 18 15:23:14 2018
New Revision: 337428

URL: http://llvm.org/viewvc/llvm-project?rev=337428&view=rev
Log:
Rename __asan_gen_* symbols to ___asan_gen_*.

This prevents gold from printing a warning when trying to export
these symbols via the asan dynamic list after ThinLTO promotes them
from private symbols to external symbols with hidden visibility.

Differential Revision: https://reviews.llvm.org/D49498

Modified:
    compiler-rt/trunk/test/asan/TestCases/Darwin/asan_gen_prefixes.cc
    compiler-rt/trunk/test/asan/TestCases/Posix/no_asan_gen_globals.c

Modified: compiler-rt/trunk/test/asan/TestCases/Darwin/asan_gen_prefixes.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Darwin/asan_gen_prefixes.cc?rev=337428&r1=337427&r2=337428&view=diff
==============================================================================
--- compiler-rt/trunk/test/asan/TestCases/Darwin/asan_gen_prefixes.cc (original)
+++ compiler-rt/trunk/test/asan/TestCases/Darwin/asan_gen_prefixes.cc Wed Jul 18 15:23:14 2018
@@ -1,4 +1,4 @@
-// Make sure __asan_gen_* strings have the correct prefixes on Darwin
+// Make sure ___asan_gen_* strings have the correct prefixes on Darwin
 // ("L" in __TEXT,__cstring, "l" in __TEXT,__const
 
 // RUN: %clang_asan %s -S -o %t.s
@@ -9,8 +9,8 @@
 int x, y, z;
 int main() { return 0; }
 // CHECK: .section{{.*}}__TEXT,__const
-// CHECK: l___asan_gen_
+// CHECK: l____asan_gen_
 // CHECK: .section{{.*}}__TEXT,__cstring,cstring_literals
-// CHECK: L___asan_gen_
-// CHECK: L___asan_gen_
-// CHECK: L___asan_gen_
+// CHECK: L____asan_gen_
+// CHECK: L____asan_gen_
+// CHECK: L____asan_gen_

Modified: compiler-rt/trunk/test/asan/TestCases/Posix/no_asan_gen_globals.c
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Posix/no_asan_gen_globals.c?rev=337428&r1=337427&r2=337428&view=diff
==============================================================================
--- compiler-rt/trunk/test/asan/TestCases/Posix/no_asan_gen_globals.c (original)
+++ compiler-rt/trunk/test/asan/TestCases/Posix/no_asan_gen_globals.c Wed Jul 18 15:23:14 2018
@@ -1,10 +1,10 @@
 // FIXME: https://code.google.com/p/address-sanitizer/issues/detail?id=316
 // XFAIL: android
-// Make sure __asan_gen_* strings do not end up in the symbol table.
+// Make sure ___asan_gen_* strings do not end up in the symbol table.
 
 // RUN: %clang_asan %s -o %t.exe
 // RUN: nm %t.exe | FileCheck %s
 
 int x, y, z;
 int main() { return 0; }
-// CHECK-NOT: __asan_gen_
+// CHECK-NOT: ___asan_gen_




More information about the llvm-commits mailing list