[PATCH] D49446: [WebAssembly] Move .debug_line section address of dead function outside section range

Yury Delendik via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 18 15:11:50 PDT 2018


yurydelendik added inline comments.


================
Comment at: wasm/InputFiles.cpp:145
     if (auto *Sym = dyn_cast<DefinedFunction>(getFunctionSymbol(Reloc.Index))) {
+      if (Sym->Function->OutputOffset == InputFunction::UNKNOWN_OUTPUT_OFFSET)
+        return DEAD_FUNCTION_OFFSET;
----------------
sbc100 wrote:
> Could/Should this be "->isLive()"?
> 
> 
> 
InputFunction/InputChunk does not provide such method. Do you want to add this attribute to the InpurtFunction?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D49446





More information about the llvm-commits mailing list