[PATCH] D49429: [ThinLTO] Enable ThinLTO WholeProgramDevirt and LowerTypeTests in new PM

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 18 14:54:14 PDT 2018


pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Passes/PassBuilder.cpp:927
+    OptimizationLevel Level, bool DebugLogging,
+    ModuleSummaryIndex *ExportSummary,
+    const ModuleSummaryIndex *ImportSummary) {
----------------
There's no need to pass `ExportSummary` into this function as it is unused (and logically can't be used because the ThinLTO phase should not be exporting anything). Similarly for `ImportSummary` into `buildLTODefaultPipeline`.


Repository:
  rL LLVM

https://reviews.llvm.org/D49429





More information about the llvm-commits mailing list