[PATCH] D49446: [WebAssembly] Move .debug_line section address of dead function outside section range

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 18 14:49:23 PDT 2018


sbc100 added a comment.

I'm still not sure I understand why writing zero here is not a good idea.



================
Comment at: wasm/InputFiles.cpp:145
     if (auto *Sym = dyn_cast<DefinedFunction>(getFunctionSymbol(Reloc.Index))) {
+      if (Sym->Function->OutputOffset == InputFunction::UNKNOWN_OUTPUT_OFFSET)
+        return DEAD_FUNCTION_OFFSET;
----------------
Could/Should this be "->isLive()"?





Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D49446





More information about the llvm-commits mailing list