[PATCH] D49405: Change the cap on the amount of padding for each vtable to 32-byte (previously it was 128-byte)

Zhaomo Yang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 18 14:35:04 PDT 2018


zhaomo planned changes to this revision.
zhaomo added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/LowerTypeTests.cpp:774-777
+    // Cap at 32 was found experimentally to have a good data/instruction
     // overhead tradeoff.
-    if (Padding > 128)
-      Padding = alignTo(InitSize, 128) - InitSize;
+    if (Padding > 32)
+      Padding = alignTo(InitSize, 32) - InitSize;
----------------
dberris wrote:
> Is it possible to have a reference to the experiment results either through a link or a document or in a comment?
How about a link to the email of the experiment results (http://lists.llvm.org/pipermail/llvm-dev/2018-July/124694.html)? Is the llvm-dev archive considered permanent? 


Repository:
  rL LLVM

https://reviews.llvm.org/D49405





More information about the llvm-commits mailing list