[PATCH] D49456: [AArch64] Support execute-only LOAD segments.

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a reviewer: ruiu.
peter.smith added a comment.

Adding Rui as code owner as he'll probably want to sign off on the introduction of a command line option.

I've got a couple of comments surrounding what happens in the linker script case. As it stands the change above will do the right thing with the default section order as all the executable sections will be in the same OutputSection and the ro-data will be separate. A hand written linker script could easily be written that could mix ro-data and code and wouldn't be caught by the  Config->SingleRoRx check. What I suggest is to either not support the option when a linker script is used, or add a check in OutputSection::addSection() that can detect if ro-data and code is mixed in the same OutputSection. Other than that the implementation looks good to me.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D49456