[PATCH] D49366: Add support for /FUNCTIONPADMIN command-line option

Stefan Reinalter via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 18 03:28:34 PDT 2018


stefan_reinalter added inline comments.


================
Comment at: COFF/Writer.cpp:761
+      if ((Padding != 0) && dyn_cast<SectionChunk>(C)) {
+        RawSize += Padding;
+        VirtualSize += Padding;
----------------
pcc wrote:
> Taking a closer look at the code, it looks like `RawSize` is updated automatically at the end of the loop, so you don't need to update it here.
Can we assume that C->hasData() is always true in this case?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D49366





More information about the llvm-commits mailing list