[PATCH] D49426: [DEBUG_INFO] fix .loc directives emitted for missing prologues

Tom Weaver via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 18 03:21:09 PDT 2018


TWeaver added a comment.

In https://reviews.llvm.org/D49426#1165555, @dblaikie wrote:

> I feel like maybe the solution here should be in the MC integrated
>  assembler - to not emit zero-length sequences in the line table, regardless
>  of whether it's in the prologue or anywhere else?


I agree.

There is future work planned (at my office) to address the interpretation of a sequence of .loc directives with no interleaved instructions.

I've hand rolled a .asm file with multiple sequential .loc directives and find similar results, regardless of prologue or otherwise.

However, this particular piece of work addresses what I perceived to be an artefact, a .loc directive for a missing prologue.

If you believe it best to address both issues within this one patch i'd be happy to accommodate.

However, I'm being ushered onto another piece of work post this patch, so may take a little bit of time to get it done.

Thanks for your time
Tom


https://reviews.llvm.org/D49426





More information about the llvm-commits mailing list