[PATCH] D49397: Pass CMAKE_C_FLAGS to the custom libc++ build too

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 17 19:28:20 PDT 2018


phosek added a comment.

What about C++ flags? libc++ is a C++ library so those are likely going to be important as well. Rather than lumping both C and C++ flags together into a single variable, we should probably consider adding two new keyword arguments to `add_custom_libcxx`, `CMAKE_C_FLAGS` and `CMAKE_CXX_FLAGS`, and use those to pass C and C++ flags separately to libc++ build.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D49397





More information about the llvm-commits mailing list