[PATCH] D49137: [dsymutil] Implement DWARF5 accelerator tables.

Frederic Riss via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 17 09:16:24 PDT 2018


friss added a comment.

In https://reviews.llvm.org/D49137#1165178, @friss wrote:

> maybeUpdateAccelKind() will make a final call about the kind of accelerator tables on the first object it encounters which has accelerator tables. This seems pretty arbitrary. I'd prefer if we considered Apple table the default unless all files are Dwarf5 and have Dwarf5 accelerator tables.
>  Other than that, the implementation looks good. I'd like to know how the LLDB test suite behaves if you force it to use the new accelerator tables.


Looks like I should have updated the review before going through the code... Let me take another look


https://reviews.llvm.org/D49137





More information about the llvm-commits mailing list