[PATCH] D49369: [llvm-readobj] - Teach tool to dump objects with >= SHN_LORESERVE of sections.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with a comment change in the test.



================
Comment at: test/tools/llvm-readobj/many-sections.s:25
+## many-sections-stripped.elf-x86_64 is many-sections.elf-x86_64 with
+## e_shoff field set to zero (so, the section header is stripped).
+
----------------
I suppose technically this is malformed, since if the section headers are stripped, the e_shstrndx should be zero. Maybe you should change the comment here to:

"... set to zero, but not e_shstrndx, to show that this corrupt case is handled correctly."


https://reviews.llvm.org/D49369