[PATCH] D49384: [IPSCCP] Do not zap return if the return value is overdefined at any call site.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 17 07:11:57 PDT 2018


fhahn added a comment.

In https://reviews.llvm.org/D49384#1164478, @efriedma wrote:

> Thought about it a bit more, came up with an alternative fix: https://reviews.llvm.org/D49408.  It's a bit more aggressive, and avoids the weirdness of calling markForcedConstant on an arbitrary value.


Great, I think back-propagating false to the condition is the biggest troublemaker, responsible for this bug and also https://reviews.llvm.org/D48327, so getting rid of it is great. And https://reviews.llvm.org/D49408 solves both problems.


https://reviews.llvm.org/D49384





More information about the llvm-commits mailing list