[PATCH] D49053: [Docs] Debugging optimized code with debugify

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

Please change the patch title to match the title of the newly-added section. I have a few more minor suggestions inline, but overall this is ready to land.



================
Comment at: docs/SourceLevelDebugging.rst:1591
+
+   # Prepend -debugify before and append -check-debugify after
+   # each pass on the pipeline (similar to -verify-each).
----------------
"append -check-debugify" -> "append -check-debugify -strip"


================
Comment at: docs/SourceLevelDebugging.rst:1604
+
+The first pass that applies synthetic DI is especially helpful when it comes
+to testing that a given pass preserves DI while transforming the module.
----------------
"first pass that applies synthetic DI" -> "-debugify pass"


================
Comment at: docs/SourceLevelDebugging.rst:1608
+regression tests. There might be occasional bug-fixes but they are not allowed
+to break existing tests or alter their meaning.
+
----------------
Here's a way to rephrase the last sentence for extra clarity: 'Changes to this pass are not allowed to break existing tests.'


================
Comment at: docs/SourceLevelDebugging.rst:1617
+
+   ; RUN: opt < %s -debugify -inst-combine -S | FileCheck %s --check-prefix=DEBUGINFO
+
----------------
"-inst-combine" -> "-instcombine"


Repository:
  rL LLVM

https://reviews.llvm.org/D49053