[PATCH] D49384: [IPSCCP] Do not zap return if the return value is overdefined at any call site.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 16 14:38:55 PDT 2018


efriedma added a comment.

Stuff like this really makes me want to kill off ResolveUndefsIn.  But this works for now.



================
Comment at: lib/Transforms/Scalar/SCCP.cpp:2021
+    if (any_of(F->users(), [&Solver](Value *U) {
+          assert(Solver.isBlockExecutable(cast<Instruction>(U)->getParent()) &&
+                 "All unreachable calls should have been removed already.");
----------------
I think `cast<Instruction>(U)` will fail if there's a BlockAddress user of F.


https://reviews.llvm.org/D49384





More information about the llvm-commits mailing list