[PATCH] D49225: [SLPVectorizer] Move scalar/vector costs to helper functions (NFCI).

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 16 10:56:03 PDT 2018


ABataev added inline comments.


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:609-610
 
+  /// \returns the cost of the scalar instruction \p I.
+  int getScalarCost(Instruction *I, Type *DstSclTy);
+
----------------
Can we just use `TTI->getInstructionCost(I, TargetTransformInfo::TCK_RecipThroughput);` instead of this function?


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:612-615
+  /// \returns the cost of a vectorized version of the scalar instruction \p I.
+  int getVectorCost(Instruction *I, ArrayRef<Value *> VL, Type *DstSclTy,
+                    VectorType *DstVecTy);
+
----------------
The same question here


Repository:
  rL LLVM

https://reviews.llvm.org/D49225





More information about the llvm-commits mailing list