[PATCH] D47904: Support option -plugin-opt=dwo_dir=

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: test/ELF/lto/thinlto-debug-fission.ll:7
+; Test to ensure that --plugin-opt=dwo_dir=$DIR creates .dwo files under $DIR
+; RUN: ld.lld --plugin-opt=dwo_dir=%T/dwo -shared %t1.o -o %t2
+; RUN: llvm-readobj -h %T/dwo/0.dwo | FileCheck %s
----------------
pcc wrote:
> yunlian wrote:
> > ruiu wrote:
> > > ruiu wrote:
> > > > If the specified directory doesn't exist, does --plug-opt=dwo_dir creates a new directory?
> > > `-o /dev/null` is preferred if you don't need an output file.
> > Yes, it will create a new directory if the specified directory does not exist.
> I'd add an `rm -rf %T/dwo` to test that and make sure that files aren't left over from previous runs.
Move the `rm -rf` before the call to `ld.lld`.


https://reviews.llvm.org/D47904