[PATCH] D49102: [AccelTable] Provide DWARF5AccelTableStaticData for dsymutil.

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 16 03:08:57 PDT 2018


labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

This looks good to me. There are some different tradeoffs we could make (speed/templates vs. code size/virtualization), but I don't have an opinion on that, so if noone else does either, I guess this is fine.



================
Comment at: llvm/include/llvm/CodeGen/AccelTable.h:319
+    ArrayRef<MCSymbol *> CUs,
+    std::function<unsigned(const DWARF5AccelTableStaticData &)>
+        getCUIndexForEntry);
----------------
If we wanted to optimize things, this could be an `llvm::function_ref`.


https://reviews.llvm.org/D49102





More information about the llvm-commits mailing list