[llvm] r337128 - [AMDGPU] adjusted test checks because minnum with NaN gets simplified

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 15 08:14:40 PDT 2018


Author: spatel
Date: Sun Jul 15 08:14:40 2018
New Revision: 337128

URL: http://llvm.org/viewvc/llvm-project?rev=337128&view=rev
Log:
[AMDGPU] adjusted test checks because minnum with NaN gets simplified

This was improved with rL337127, but I missed the failure in this test.
I'm not sure what the expected result will be, so I've generalized it
and added a FIXME comment.

Modified:
    llvm/trunk/test/CodeGen/AMDGPU/fcanonicalize-elimination.ll

Modified: llvm/trunk/test/CodeGen/AMDGPU/fcanonicalize-elimination.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AMDGPU/fcanonicalize-elimination.ll?rev=337128&r1=337127&r2=337128&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/AMDGPU/fcanonicalize-elimination.ll (original)
+++ llvm/trunk/test/CodeGen/AMDGPU/fcanonicalize-elimination.ll Sun Jul 15 08:14:40 2018
@@ -379,11 +379,12 @@ define amdgpu_kernel void @test_fold_can
   ret void
 }
 
+; FIXME: Should there be more checks here? minnum with NaN operand is simplified away.
+
 ; GCN-LABEL: test_fold_canonicalize_sNaN_value_f32:
-; GCN:  v_min_f32_e32 [[V0:v[0-9]+]], 0x7f800001, v{{[0-9]+}}
-; GCN-FLUSH:  v_mul_f32_e32 [[RESULT:v[0-9]+]], 1.0, [[V0]]
-; GCN-DENORM: v_max_f32_e32 [[RESULT:v[0-9]+]], [[V0]], [[V0]]
-; GCN:  {{flat|global}}_store_dword v[{{[0-9:]+}}], [[RESULT]]
+; VI:   v_add_u32_e32 v{{[0-9]+}}
+; GFX9:	v_add_co_u32_e32 v{{[0-9]+}}
+; GCN:  {{flat|global}}_store_dword v[{{[0-9:]+}}]
 define amdgpu_kernel void @test_fold_canonicalize_sNaN_value_f32(float addrspace(1)* %arg) {
   %id = tail call i32 @llvm.amdgcn.workitem.id.x()
   %gep = getelementptr inbounds float, float addrspace(1)* %arg, i32 %id




More information about the llvm-commits mailing list