[PATCH] D49346: [CMake] Use cxx-headers as a depedency for C++ headers

[Petr Hosek via Phabricator via llvm-commits]

phosek created this revision.
phosek added reviewers: dberris, vitalybuka, morehouse.
Herald added subscribers: Sanitizers, llvm-commits, mgorny.

We no longer pass CLANG_DEFAULT_CXX_STDLIB to the runtimes build
as it was causing issues so we can no longer use this variable. We
instead use cxx-headers as a dependency whenever this is available
since both XRay and libFuzzer are built as static libraries so this
is sufficient.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D49346

Files:
  compiler-rt/lib/fuzzer/CMakeLists.txt
  compiler-rt/lib/xray/CMakeLists.txt


Index: compiler-rt/lib/xray/CMakeLists.txt
===================================================================
--- compiler-rt/lib/xray/CMakeLists.txt
+++ compiler-rt/lib/xray/CMakeLists.txt
@@ -133,8 +133,8 @@
     RTSanitizerCommon
     RTSanitizerCommonLibc)
 
-if (CLANG_DEFAULT_CXX_STDLIB STREQUAL "libc++" AND (TARGET cxx OR HAVE_LIBCXX))
-  set(XRAY_DEPS cxx)
+if (TARGET cxx-headers OR HAVE_LIBCXX)
+  set(XRAY_DEPS cxx-headers)
 endif()
 
 if (APPLE)
Index: compiler-rt/lib/fuzzer/CMakeLists.txt
===================================================================
--- compiler-rt/lib/fuzzer/CMakeLists.txt
+++ compiler-rt/lib/fuzzer/CMakeLists.txt
@@ -59,8 +59,8 @@
   list(APPEND LIBFUZZER_CFLAGS -nostdinc++ -D_LIBCPP_ABI_VERSION=Fuzzer)
   # Remove -stdlib= which is unused when passing -nostdinc++.
   string(REGEX REPLACE "-stdlib=[a-zA-Z+]*" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})
-elseif(CLANG_DEFAULT_CXX_STDLIB STREQUAL "libc++" AND (TARGET cxx OR HAVE_LIBCXX))
-  set(LIBFUZZER_DEPS cxx)
+elseif(TARGET cxx-headers OR HAVE_LIBCXX)
+  set(LIBFUZZER_DEPS cxx-headers)
 endif()
 
 append_list_if(COMPILER_RT_HAS_OMIT_FRAME_POINTER_FLAG -fno-omit-frame-pointer LIBFUZZER_CFLAGS)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49346.155578.patch
Type: text/x-patch
Size: 1194 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180715/d630f108/attachment-0001.bin>