[PATCH] D49219: [Sparc] Custom bitcast between f64 and v2i32

James Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 14 08:19:56 PDT 2018


jrtc27 added inline comments.


================
Comment at: lib/Target/Sparc/SparcISelLowering.cpp:3061
+
+  assert(VT == MVT::v2i32 || VT == MVT::f64);
+  
----------------
Should we also be checking `Src.getSimpleValueType()`? This only works if both source and result are v2i32/f64.


Repository:
  rL LLVM

https://reviews.llvm.org/D49219





More information about the llvm-commits mailing list