[PATCH] D49329: [llvm-mca] Turn InstructionTables into a Stage.

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 13 16:20:30 PDT 2018


mattd added inline comments.


================
Comment at: tools/llvm-mca/InstructionTables.h:40
   void addView(std::unique_ptr<View> V) {
+    addListener(V.get());
     Views.emplace_back(std::move(V));
----------------
I'm working on a follow on patch to clean this addListener call up.


================
Comment at: tools/llvm-mca/llvm-mca.cpp:507
+      P->run();
+      OrigPtr->printReport(TOF->os());
       continue;
----------------
A follow on patch will clean this printReport up.


https://reviews.llvm.org/D49329





More information about the llvm-commits mailing list