[PATCH] D48670: [ThinLTO] Ensure we always select the same function copy to import

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson marked 2 inline comments as done.
tejohnson added inline comments.


================
Comment at: test/Transforms/FunctionImport/funcimport_resolved.ll:32
+; INSTLIM8: Is importing function {{.*}} foo from {{.*}}funcimport_resolved1.ll
+; INSTLIM8: Is importing function {{.*}} linkonceodrfunc from {{.*}}funcimport_resolved1.ll
+; INSTLIM8: Not importing function {{.*}} linkonceodrfunc2 from {{.*}}funcimport_resolved1.ll
----------------
davidxl wrote:
> Is or Not importing here?
The comments in the test case were not correct. What we want to check is that we only import the copy from funcimport_resolved1, and not *also* the copy from funcimport_resolved2. Without this patch we decide to import both. The reason is that without the patch we track the import thresholds for each module we are importing from, so we don't properly detect that we have already imported a copy from funcimport_resolved1 when we try to import again at the lower threshold.


Repository:
  rL LLVM

https://reviews.llvm.org/D48670