[PATCH] D48046: [test-suite] Backprop kernel from Rodinia Benchmark

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 13 12:28:01 PDT 2018


MatzeB requested changes to this revision.
MatzeB added a comment.
This revision now requires changes to proceed.

- Patches should be relative to the toplevel test-suite directory.
- 94k of reference output seems a lot and smells like you may end up in the anti-pattern of spending most of the benchmark time in printing instead of doing calculations.
- We currently tend to not add `-ffast-math` as part of the makefiles, but instead people choose it together with their other optimization flags.
- How long does this benchmark run? (We aim for 0.5-1s on typical PC hardware); Bonus points if the duration can be changed from the commandline (no expections for matching reference outputs for different input size though).
- `srand()`/`rand()` produce different output with different libc implementations!


Repository:
  rT test-suite

https://reviews.llvm.org/D48046





More information about the llvm-commits mailing list