[PATCH] D49279: Allow SyntheticChildFrontEnd's to request that they always get an object, nor a reference or pointer

Jim Ingham via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 13 10:26:30 PDT 2018


jingham added a comment.

I didn't want to make check_ii sound general with a name like check_bitset.  This isn't some general bitset check routine, it asserts the state of the particular bitset held in ii at a particular point in the program execution.   The only reason to extract the test into a routine was to apply the exact same test for the contents of ii when it appeared as that object or as a reference to it.   For that reason I'm not unhappy with the name, but I added a comment explaining what the routine does.  Does that make it clearer?


Repository:
  rL LLVM

https://reviews.llvm.org/D49279





More information about the llvm-commits mailing list