[PATCH] D48887: [TableGen] Suppress type validation when parsing pattern fragments

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 13 09:32:19 PDT 2018


hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: utils/TableGen/CodeGenDAGPatterns.cpp:3026
+    {
+      TypeInfer::SuppressValidation _1(ThePat.getInfer());
+      ThePat.InferAllTypes();
----------------
I'd name this SV, or something, instead of _1. Seeing a name with an underscore, at least for me, draws attention unnecessarily.


Repository:
  rL LLVM

https://reviews.llvm.org/D48887





More information about the llvm-commits mailing list