[PATCH] D49261: [lldbsuite] The test inside TestOverloadedFunctions.py has the wrong class name

Stella Stamenova via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 12 11:30:36 PDT 2018


stella.stamenova created this revision.
stella.stamenova added reviewers: asmith, zturner.
Herald added a subscriber: llvm-commits.

It looks like the test file was copied from TestCPPStaticMethods.py because they have the same name. This means that the two tests will try to write to the same output files and will either overwrite each other's output or occasionally cause failures because they can't both access the same file.


Repository:
  rL LLVM

https://reviews.llvm.org/D49261

Files:
  packages/Python/lldbsuite/test/lang/cpp/overloaded-functions/TestOverloadedFunctions.py


Index: packages/Python/lldbsuite/test/lang/cpp/overloaded-functions/TestOverloadedFunctions.py
===================================================================
--- packages/Python/lldbsuite/test/lang/cpp/overloaded-functions/TestOverloadedFunctions.py
+++ packages/Python/lldbsuite/test/lang/cpp/overloaded-functions/TestOverloadedFunctions.py
@@ -8,7 +8,7 @@
 from lldbsuite.test import lldbutil
 
 
-class CPPStaticMethodsTestCase(TestBase):
+class OverloadedFunctionsTestCase(TestBase):
 
     mydir = TestBase.compute_mydir(__file__)
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49261.155235.patch
Type: text/x-patch
Size: 543 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180712/a0a8bd36/attachment.bin>


More information about the llvm-commits mailing list