[PATCH] D49259: [MIPS] Fix local dynamic TLS with Sym64

James Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 12 11:16:55 PDT 2018


jrtc27 created this revision.
jrtc27 added a reviewer: atanasyan.
Herald added subscribers: llvm-commits, arichardson, sdardis.

For the final DTPREL addition, rather than a lui/daddiu/daddu triple,
LLVM was erronously emitting a daddiu/daddiu pair, treating the
%dtprel_hi as if it were a %dtprel_lo, since Mips::Hi expands unshifted
for Sym64. Instead, use a new DtprelHi node and, although unnecessary
due to the exact structure of the nodes emitted, use TprelHi for local
exec too to prevent future bugs. Also garbage-collect the unused TprelLo
and TlsGd nodes.


Repository:
  rL LLVM

https://reviews.llvm.org/D49259

Files:
  lib/Target/Mips/MicroMipsInstrInfo.td
  lib/Target/Mips/Mips16InstrInfo.td
  lib/Target/Mips/Mips64InstrInfo.td
  lib/Target/Mips/MipsISelLowering.cpp
  lib/Target/Mips/MipsISelLowering.h
  lib/Target/Mips/MipsInstrInfo.td
  test/CodeGen/Mips/tls.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49259.155228.patch
Type: text/x-patch
Size: 14422 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180712/3f1f637b/attachment.bin>


More information about the llvm-commits mailing list