[PATCH] D49153: [XRay][compiler-rt] Add PID field to llvm-xray tool and add PID metadata record entry in FDR mode

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 12 01:22:13 PDT 2018


dberris added a comment.

In https://reviews.llvm.org/D49153#1159578, @Maknee wrote:

> In https://reviews.llvm.org/D49153#1159577, @dberris wrote:
>
> > Thanks @Maknee -- now if you look in `llvm/test/tools/llvm-xray/X86` you'll find some tests for the llvm-xray tool. Also, in the `Inputs` sub-directory, you'll find sample XRay traces of the old versions. It would be great if you can add version 3 sample binary traces there and add more tests to ensure that we are getting the expected data from the tools handling the newer version(s) of the traces.
>
>
> Okay, will do.


I realise that I may have been a little unclear here.

To be clear, the suggestion is to create a binary that's XRay-instrumented and get version 3 files generated from those (for FDR mode). We don't need to keep the binary in the `Inputs` directory, we just need the trace file generated from this binary.


https://reviews.llvm.org/D49153





More information about the llvm-commits mailing list