[PATCH] D49211: [x86] Fix EFLAGS copy lowering to correctly handle walking past uses in multiple successors where some of the uses end up killing the EFLAGS register.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 11 17:47:33 PDT 2018


chandlerc created this revision.
chandlerc added reviewers: craig.topper, echristo, bogner.
Herald added subscribers: hiraditya, mcrosier, sanjoy.

There was a bug where rather than skipping to the next basic block
queued up with uses once we saw a kill, we stopped processing the blocks
entirely. =/

Test case produces completely nonsensical code w/o this tiny fix.

This was found testing Speculative Load Hardening and split out of that
work.


Repository:
  rL LLVM

https://reviews.llvm.org/D49211

Files:
  llvm/lib/Target/X86/X86FlagsCopyLowering.cpp
  llvm/test/CodeGen/X86/flags-copy-lowering.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49211.155098.patch
Type: text/x-patch
Size: 3616 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180712/429be540/attachment.bin>


More information about the llvm-commits mailing list