[PATCH] D49153: [XRay][compiler-rt] Add PID field to llvm-xray tool and add PID metadata record entry in FDR mode

[Dean Michael Berris via Phabricator via llvm-commits]

dberris added inline comments.


================
Comment at: llvm/lib/XRay/Trace.cpp:390-397
+       else
+       {
+         // In Version 3 and and above, a PidRecord is expected after WallTimeRecord
+         if (Version >= 3)
+         {
+           State.Expects = FDRState::Token::PID_RECORD;
+         }
----------------
You don't need the else branch because of the body of the first if already returns.

You also don't need the curly braces for one-line if statements.


================
Comment at: llvm/tools/llvm-xray/xray-account.cpp:479-481
+               R"({{type: {0}; cpu: {1}; record-type: {2}; function-id: {3}; tsc: {4}; thread-id: {5}; process-id: {6}}})",
+               Record.RecordType, Record.CPU, Record.Type, Record.FuncId, Record.TSC,
+               Record.TId, Record.PId)
----------------
Did clang-format do this?


https://reviews.llvm.org/D49153