[PATCH] D49177: [CMake] Remove unnecesary list of source files for Xray unit tests.

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 11 16:53:34 PDT 2018


dberris accepted this revision.
dberris added a subscriber: nglevin.
dberris added a comment.
This revision is now accepted and ready to land.

LGTM -- @nglevin was working on getting the XRay unit tests at least build and run but got interrupted.

The original reason for doing this was to ensure that when any of the implementation files changed, that the unit tests would be built. As you've learned this only made sense for platforms where the tests are built and run.

I'm fine with landing this then iterating, no need for me to test myself.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D49177





More information about the llvm-commits mailing list