[PATCH] D48650: [analyzer] Fix constraint being dropped when analyzing a program without taint tracking enabled

George Karpenkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 11 11:57:20 PDT 2018


george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.

LGTM with a nit. We'll watch the bots after this is merged.



================
Comment at: test/Analysis/bitwise-ops.c:11
   
   // False positives due to SValBuilder giving up on certain kinds of exprs.
+  CHECK(1 - x); // expected-warning{{TRUE}}
----------------
I think this comment can be dropped.


https://reviews.llvm.org/D48650





More information about the llvm-commits mailing list