[PATCH] D49173: [DebugInfo] Make children iterator bidirectional

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 11 10:01:41 PDT 2018


JDevlieghere marked an inline comment as done.
JDevlieghere added a comment.

Thanks for the review!



================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp:626
+      return DWARFDie(this, &DieArray[I]);
+  }
+  return DWARFDie();
----------------
dblaikie wrote:
> Maybe assert that DieArray[I].getDepth() > Depth - to ensure it didn't some how jump out of the children?
Good idea, I'll add that before committing. 


https://reviews.llvm.org/D49173





More information about the llvm-commits mailing list