[llvm] r336792 - Recommit r336653: [VPlan] Add VPlanTestBase.h with helper

[Florian Hahn via llvm-commits]

Author: fhahn
Date: Wed Jul 11 04:54:30 2018
New Revision: 336792

URL: http://llvm.org/viewvc/llvm-project?rev=336792&view=rev
Log:
Recommit r336653: [VPlan] Add VPlanTestBase.h with helper

The original version caused a memsan failure.

Added:
    llvm/trunk/unittests/Transforms/Vectorize/VPlanTestBase.h
Modified:
    llvm/trunk/unittests/Transforms/Vectorize/VPlanHCFGTest.cpp

Modified: llvm/trunk/unittests/Transforms/Vectorize/VPlanHCFGTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Transforms/Vectorize/VPlanHCFGTest.cpp?rev=336792&r1=336791&r2=336792&view=diff
==============================================================================
--- llvm/trunk/unittests/Transforms/Vectorize/VPlanHCFGTest.cpp (original)
+++ llvm/trunk/unittests/Transforms/Vectorize/VPlanHCFGTest.cpp Wed Jul 11 04:54:30 2018
@@ -8,35 +8,16 @@
 //===----------------------------------------------------------------------===//
 
 #include "../lib/Transforms/Vectorize/VPlan.h"
-#include "../lib/Transforms/Vectorize/VPlanHCFGBuilder.h"
 #include "../lib/Transforms/Vectorize/VPlanHCFGTransforms.h"
-#include "llvm/AsmParser/Parser.h"
-#include "llvm/IR/Dominators.h"
+#include "VPlanTestBase.h"
 #include "gtest/gtest.h"
 
 namespace llvm {
 namespace {
 
-class VPlanHCFGTest : public testing::Test {
-protected:
-  std::unique_ptr<DominatorTree> DT;
-  std::unique_ptr<LoopInfo> LI;
-
-  VPlanHCFGTest() {}
-
-  VPlanPtr doBuildPlan(BasicBlock *LoopHeader) {
-    DT.reset(new DominatorTree(*LoopHeader->getParent()));
-    LI.reset(new LoopInfo(*DT));
-
-    auto Plan = llvm::make_unique<VPlan>();
-    VPlanHCFGBuilder HCFGBuilder(LI->getLoopFor(LoopHeader), LI.get());
-    HCFGBuilder.buildHierarchicalCFG(*Plan.get());
-    return Plan;
-  }
-};
+class VPlanHCFGTest : public VPlanTestBase {};
 
 TEST_F(VPlanHCFGTest, testBuildHCFGInnerLoop) {
-  LLVMContext Ctx;
   const char *ModuleString =
       "define void @f(i32* %A, i64 %N) {\n"
       "entry:\n"
@@ -54,12 +35,11 @@ TEST_F(VPlanHCFGTest, testBuildHCFGInner
       "  ret void\n"
       "}\n";
 
-  SMDiagnostic Err;
-  std::unique_ptr<Module> M = parseAssemblyString(ModuleString, Err, Ctx);
+  Module &M = parseModule(ModuleString);
 
-  Function *F = M->getFunction("f");
+  Function *F = M.getFunction("f");
   BasicBlock *LoopHeader = F->getEntryBlock().getSingleSuccessor();
-  auto Plan = doBuildPlan(LoopHeader);
+  auto Plan = buildHCFG(LoopHeader);
 
   VPBasicBlock *Entry = Plan->getEntry()->getEntryBasicBlock();
   EXPECT_NE(nullptr, Entry->getSingleSuccessor());
@@ -115,7 +95,6 @@ TEST_F(VPlanHCFGTest, testBuildHCFGInner
 }
 
 TEST_F(VPlanHCFGTest, testVPInstructionToVPRecipesInner) {
-  LLVMContext Ctx;
   const char *ModuleString =
       "define void @f(i32* %A, i64 %N) {\n"
       "entry:\n"
@@ -133,12 +112,11 @@ TEST_F(VPlanHCFGTest, testVPInstructionT
       "  ret void\n"
       "}\n";
 
-  SMDiagnostic Err;
-  std::unique_ptr<Module> M = parseAssemblyString(ModuleString, Err, Ctx);
+  Module &M = parseModule(ModuleString);
 
-  Function *F = M->getFunction("f");
+  Function *F = M.getFunction("f");
   BasicBlock *LoopHeader = F->getEntryBlock().getSingleSuccessor();
-  auto Plan = doBuildPlan(LoopHeader);
+  auto Plan = buildHCFG(LoopHeader);
 
   LoopVectorizationLegality::InductionList Inductions;
   SmallPtrSet<Instruction *, 1> DeadInstructions;

Added: llvm/trunk/unittests/Transforms/Vectorize/VPlanTestBase.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Transforms/Vectorize/VPlanTestBase.h?rev=336792&view=auto
==============================================================================
--- llvm/trunk/unittests/Transforms/Vectorize/VPlanTestBase.h (added)
+++ llvm/trunk/unittests/Transforms/Vectorize/VPlanTestBase.h Wed Jul 11 04:54:30 2018
@@ -0,0 +1,61 @@
+//===- llvm/unittest/Transforms/Vectorize/VPlanTestBase.h -----------------===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+/// \file
+/// This file defines a VPlanTestBase class, which provides helpers to parse
+/// a LLVM IR string and create VPlans given a loop entry block.
+//===----------------------------------------------------------------------===//
+#ifndef LLVM_UNITTESTS_TRANSFORMS_VECTORIZE_VPLANTESTBASE_H
+#define LLVM_UNITTESTS_TRANSFORMS_VECTORIZE_VPLANTESTBASE_H
+
+#include "../lib/Transforms/Vectorize/VPlan.h"
+#include "../lib/Transforms/Vectorize/VPlanHCFGBuilder.h"
+#include "llvm/Analysis/LoopInfo.h"
+#include "llvm/AsmParser/Parser.h"
+#include "llvm/IR/Dominators.h"
+#include "llvm/Support/SourceMgr.h"
+#include "gtest/gtest.h"
+
+namespace llvm {
+
+/// Helper class to create a module from an assembly string and VPlans for a
+/// given loop entry block.
+class VPlanTestBase : public testing::Test {
+protected:
+  std::unique_ptr<LLVMContext> Ctx;
+  std::unique_ptr<Module> M;
+  std::unique_ptr<LoopInfo> LI;
+  std::unique_ptr<DominatorTree> DT;
+
+  VPlanTestBase() : Ctx(new LLVMContext) {}
+
+  Module &parseModule(const char *ModuleString) {
+    SMDiagnostic Err;
+    M = parseAssemblyString(ModuleString, Err, *Ctx);
+    EXPECT_TRUE(M);
+    return *M;
+  }
+
+  void doAnalysis(Function &F) {
+    DT.reset(new DominatorTree(F));
+    LI.reset(new LoopInfo(*DT));
+  }
+
+  VPlanPtr buildHCFG(BasicBlock *LoopHeader) {
+    doAnalysis(*LoopHeader->getParent());
+
+    auto Plan = llvm::make_unique<VPlan>();
+    VPlanHCFGBuilder HCFGBuilder(LI->getLoopFor(LoopHeader), LI.get());
+    HCFGBuilder.buildHierarchicalCFG(*Plan.get());
+    return Plan;
+  }
+};
+
+} // namespace llvm
+
+#endif // LLVM_UNITTESTS_TRANSFORMS_VECTORIZE_VPLANTESTBASE_H