[PATCH] D49116: Setup clang-format as an Arcanist linter

Siddhartha Bagaria via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 11 00:23:50 PDT 2018


starsid marked an inline comment as done.
starsid added a comment.

In https://reviews.llvm.org/D49116#1158292, @dberris wrote:

> One concern here would be whether this would even work on Windows, and whether it might make more sense to use a more portable scripting language to do it instead (say, Python). I don't use Windows so I'll let someone else who does (and uses Arcanist as well) to chime in as to whether this is going to be a problem.


I don't have a Windows machine to test, but maybe someone can port the bash script to python, while testing it on Windows. I don't mind if we don't commit this revision now, but someone takes over, and changes it to work on Windows.


Repository:
  rL LLVM

https://reviews.llvm.org/D49116





More information about the llvm-commits mailing list