[PATCH] D49153: [XRay][compiler-rt] Add PID field to llvm-xray tool and add PID metadata record entry in FDR mode

[Dean Michael Berris via Phabricator via llvm-commits]

dberris requested changes to this revision.
dberris added a comment.
This revision now requires changes to proceed.

This is where we're going to need to update the log version, because the tool(s) need to handle older versions of the log which don't contain the PID records.

Do the tests pass when you do `make check-all` or `ninja check-all`?



================
Comment at: llvm/lib/XRay/Trace.cpp:271
   // purposes. For now, we're ignoring these records.
+  State.Expects = FDRState::Token::PID_RECORD;
+  return Error::success();
----------------
This has to be conditional on the version of the log, otherwise older version logs can't be handled by the tool. We try to be backwards-compatible to a degree, until we explicitly drop support for older versions.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D49153