[PATCH] D49043: [llvm-objdump] Add -demangle (-C) option

Paul Semel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 10 14:46:08 PDT 2018


paulsemel added inline comments.


================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:336
+void llvm::warn(StringRef Message) {
+  errs() << ToolName << ": warning: " << Message << ".\n";
+}
----------------
jhenderson wrote:
> Do you need to do `errs().flush()` like in the other error methods?
> 
> Also, I'd move this to be before or after the two `error()` functions rather than in between them.
I can add `errs().flush()`, but with the `\n`, it should be flushed !


Repository:
  rL LLVM

https://reviews.llvm.org/D49043





More information about the llvm-commits mailing list