[PATCH] D49126: [PredicateInfo] Use custom mangling to support ssa_copy with unnamed types.

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 154881.
fhahn added a comment.

Thanks Eli! I am not really happy with the solution, but as discussed in https://reviews.llvm.org/D48541 solving that generally seems quite an invasive change.

I also thought about bitcasting the argument and return type of the intrinsic to and from i8* (as you suggested as another alternative), but this makes the IR more verbose, as we would have to use casts for all struct types/pointers to structs as they could contain unnamed types at any level and it would make life harder for users of PredicateInfo.


https://reviews.llvm.org/D49126

Files:
  include/llvm/Transforms/Utils/PredicateInfo.h
  lib/Transforms/Utils/PredicateInfo.cpp
  test/Transforms/NewGVN/pr33305.ll
  test/Transforms/Util/PredicateInfo/condprop.ll
  test/Transforms/Util/PredicateInfo/diamond.ll
  test/Transforms/Util/PredicateInfo/edge.ll
  test/Transforms/Util/PredicateInfo/testandor.ll
  test/Transforms/Util/PredicateInfo/unnamed-types.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49126.154881.patch
Type: text/x-patch
Size: 26607 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180710/9904859d/attachment.bin>