[PATCH] D49144: [FunctionAttrs] Infer the speculatable attribute

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 10 11:39:55 PDT 2018


efriedma added inline comments.


================
Comment at: lib/Transforms/IPO/FunctionAttrs.cpp:1207
+      if (SCCNodes.count(Callee) > 0)
+        return false;
+
----------------
I don't think we can completely ignore calls to functions within the current SCC: we also have to ensure the call itself is never UB due to violating some attribute on the call (like nonnull; see D49041).


Repository:
  rL LLVM

https://reviews.llvm.org/D49144





More information about the llvm-commits mailing list