[PATCH] D49111: [windows] LLDB shows the wrong values when register read is executed at a frame other than zero

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova marked 8 inline comments as done.
stella.stamenova added a comment.

I made the requested changes and I'll update the revision once all the tests pass.



================
Comment at: source/Plugins/Process/Windows/Common/TargetThreadWindows.cpp:92
+    Unwind *unwinder = GetUnwinder();
+    if (unwinder)
+      reg_ctx_sp = unwinder->CreateRegisterContextForFrame(frame);
----------------
tatyana-krasnukha wrote:
> aleksandr.urakov wrote:
> > tatyana-krasnukha wrote:
> > > Here you check plain pointer, don't cast it to bool - compare with nullptr.
> > What are the disadvantages of casting to bool in comparison with nullptr checking?
> That's a matter of opinion, but most coding styles consider implicit casts as less readable. E.g. if you run clang-tidy with enabled readability checks, you get readability-implicit-bool-conversion warning on this code.
I actually intentionally copied this line and several of the others verbatim from the other targets (so that they are the same) but I can fix both places.


Repository:
  rL LLVM

https://reviews.llvm.org/D49111