[PATCH] D49013: [Support] Allow formatv() to consume llvm::Error by-value without crashing.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a subscriber: sammccall.
dblaikie added a comment.

That seems plausible (op<< for Error) - but does that handle the case
mentioned above "we may not actually want to produce the string (eg: if the
Logger implementation decides to filter out the formatv_object_base based
on level)" - is op<< still called even with this filtering? (seems like if
it was, then it wouldn't avoid the stringification costs? but if it doesn't
call the op<< then it'll still fail the consume semantic requirement of
llvm::Error)


Repository:
  rL LLVM

https://reviews.llvm.org/D49013