[PATCH] D49116: Setup clang-format as an Arcanist linter

[Dean Michael Berris via Phabricator via llvm-commits]

dberris added inline comments.


================
Comment at: .arcanist/linters/clang-format.sh:12-13
+  NC='\033[0m' # No Color
+  echo -e "${RED}Please install clang-format-diff for arcanist to lint C/C++ source code.${NC}" >&2
+  exit 1
+fi
----------------
What happens when the script exits with a non-zero value? Does it stop the upload/update of the patch? I suspect we don't really want to make that a hard requirement yet, unless we get agreement from llvm-dev that this is something we should enforce for all patches moving forward.


================
Comment at: .arclint:8
+      "include": [
+        "(\\.(cpp|h)$)"
+      ]
----------------
Should this also include '.cc' files?


Repository:
  rL LLVM

https://reviews.llvm.org/D49116