[PATCH] D49123: [test cases] add test cases for find more abs pattern

[ChenZheng via Phabricator via llvm-commits]

shchenz added a comment.

@spatel Hi Sanjay, thanks very much for your comment. I have updated the description. For duplicated test case issue, "@abs_canonical_2" and @nabs_canonical_2" is for |x|, but my three case is for |-a|, |a-b| for int and vector. I am not clear you mean which one is duplicated?



================
Comment at: llvm/test/Transforms/InstCombine/abs-1.ll:149
+
+define i32 @abs_canonical_8(i32 %a) {
+; CHECK-LABEL: @abs_canonical_8(
----------------
spatel wrote:
> This is just verifying that the code does not change?
This case is for later abs pattern finding in D48754. with current master branch, there is no change to this code. I can surely add some other pred like sle to icmp to test some canonicalization for icmp. But I think this is not this test's purpose, so I let it unchanged. Should every case need changed even it is a baseline for later patch?


https://reviews.llvm.org/D49123