[PATCH] D49111: [windows] LLDB shows the wrong values when register read is executed at a frame other than zero

[Aleksandr Urakov via Phabricator via llvm-commits]

aleksandr.urakov added inline comments.


================
Comment at: source/Plugins/Process/Windows/Common/TargetThreadWindows.cpp:92
+    Unwind *unwinder = GetUnwinder();
+    if (unwinder)
+      reg_ctx_sp = unwinder->CreateRegisterContextForFrame(frame);
----------------
tatyana-krasnukha wrote:
> Here you check plain pointer, don't cast it to bool - compare with nullptr.
What are the disadvantages of casting to bool in comparison with nullptr checking?


Repository:
  rL LLVM

https://reviews.llvm.org/D49111