[PATCH] D49043: [llvm-objdump] Add -demangle (-C) option

[Paul Semel via Phabricator via llvm-commits]

paulsemel added inline comments.


================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:1523
+      StringRef SymbolName = std::get<1>(Symbols[si]);
+      if (Demangle.getValue() != "none") {
+        char *DemangledSymbol = nullptr;
----------------
jhenderson wrote:
> Would it perhaps make sense to reject/warn for styles that don't make sense?
Maybe we should just warn, as we still want the disassembling happen right ?


Repository:
  rL LLVM

https://reviews.llvm.org/D49043