[PATCH] D49055: [compiler-rt] [builtins] Implement the __chkstk function for ARM for MinGW

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

Microsoft's implementation also checks the stack allocation against the thread's stack limit. Do you care about doing that?

LGTM otherwise, but I'd prefer to wait for @compnerd to take a look. (He's on vacation this week, but he'll be back next week.)



================
Comment at: lib/builtins/arm/chkstk.S:10
+
+// This clobbers the register r12, and uses r5 and r6 as temporaries
+// by backing them up and restoring them afterwards.
----------------
It also clobbers the condition codes. We were bitten by this before; see https://reviews.llvm.org/rL311061.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D49055